[fix] Correct holiday test and update version #1431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
We are comparing holidays by names, but the holidays python package translates 'erster mai' to labor day, which results in two labor days (US and german one), so that the number of holidays are not the same in english and german language (depends on the system language).
This only appears in the newest version of holidays, but I think we should fix that so that we can upgrade holidays
🔮 Key changes
removed line in test
Certainly! Below are the tables for each year, listing the name of the holiday for each date as per the terminal and VS Code data.
Table for 2009