-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix prophet tutorial #1332
Conversation
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1332 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 38 38
Lines 5109 5109
=======================================
Hits 4591 4591
Misses 518 518 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fixes, thank you!
I corrected the now added support for Conditional seasonality to be included.
Further, I think we can drop
https://github.com/ourownstory/neural_prophet/blob/fix-prophet-tutorial/docs/source/how-to-guides/changes-from-prophet.md
Do you mind quickly checking if it's contents are contained within this guide?
(feel free to merge this and remove it in a separate PR)
Finally, I remember we also had a tutorial for moving from prophet to NeuralProphet (not just TorchProphet). I just checked, but could not resurface it quickly again. However, it is the more important of the two, and we should revive it if anyhow possible.
🔬 Background
🔮 Key changes