Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix prophet tutorial #1332

Merged
merged 4 commits into from
May 20, 2023
Merged

[docs] Fix prophet tutorial #1332

merged 4 commits into from
May 20, 2023

Conversation

leoniewgnr
Copy link
Collaborator

@leoniewgnr leoniewgnr commented May 18, 2023

🔬 Background

🔮 Key changes

  • Workaround: code in markdown cell

@github-actions
Copy link

github-actions bot commented May 18, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 13.032 12.3 -5.62% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 60.3584 56.34 -6.66% 🎉
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.51721 5.13 -7.02% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@leoniewgnr leoniewgnr self-assigned this May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1332 (15b71e9) into main (24fd354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          38       38           
  Lines        5109     5109           
=======================================
  Hits         4591     4591           
  Misses        518      518           

@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label May 18, 2023
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes, thank you!

I corrected the now added support for Conditional seasonality to be included.

Further, I think we can drop
https://github.com/ourownstory/neural_prophet/blob/fix-prophet-tutorial/docs/source/how-to-guides/changes-from-prophet.md
Do you mind quickly checking if it's contents are contained within this guide?
(feel free to merge this and remove it in a separate PR)

Finally, I remember we also had a tutorial for moving from prophet to NeuralProphet (not just TorchProphet). I just checked, but could not resurface it quickly again. However, it is the more important of the two, and we should revive it if anyhow possible.

@leoniewgnr leoniewgnr merged commit 2706974 into main May 20, 2023
@leoniewgnr leoniewgnr deleted the fix-prophet-tutorial branch May 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from prophet jupyter notebook does not build for docs
3 participants