Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Ruff fixes #1327

Merged
merged 13 commits into from
May 16, 2023
Merged

[refactor] Ruff fixes #1327

merged 13 commits into from
May 16, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented May 13, 2023

Fix all ruff warnings, depends on #1324 ⚠️

@github-actions
Copy link

github-actions bot commented May 13, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 16.0265 13.16 -17.89% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 -0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 -0.0%
YosemiteTemps Loss_val 0.00077 0.00077 -0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 -0.0%
YosemiteTemps time 75.3192 62.52 -16.99% 🎉
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9452 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.74718 5.58 -17.3% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #1327 (d7df641) into main (2cf8c04) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   89.85%   89.86%           
=======================================
  Files          38       38           
  Lines        5104     5109    +5     
=======================================
+ Hits         4586     4591    +5     
  Misses        518      518           
Impacted Files Coverage Δ
...uralprophet/components/future_regressors/linear.py 100.00% <ø> (ø)
neuralprophet/components/seasonality/fourier.py 97.14% <ø> (ø)
neuralprophet/components/trend/piecewise_linear.py 92.55% <ø> (ø)
neuralprophet/configure.py 90.18% <ø> (ø)
neuralprophet/data/process.py 92.56% <ø> (ø)
neuralprophet/data/split.py 90.81% <ø> (ø)
neuralprophet/plot_forecast_matplotlib.py 84.47% <ø> (ø)
neuralprophet/plot_model_parameters_plotly.py 94.95% <ø> (ø)
neuralprophet/plot_utils.py 88.01% <ø> (ø)
neuralprophet/time_dataset.py 94.88% <ø> (ø)
... and 9 more

@noxan noxan requested a review from leoniewgnr May 16, 2023 09:23
Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@leoniewgnr leoniewgnr added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels May 16, 2023
@noxan noxan merged commit 24fd354 into main May 16, 2023
@noxan noxan deleted the ruff-fixes branch May 16, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants