Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster.js and interactive.js have invalid import references #90

Closed
gjabell opened this issue Jan 9, 2019 · 2 comments
Closed

cluster.js and interactive.js have invalid import references #90

gjabell opened this issue Jan 9, 2019 · 2 comments

Comments

@gjabell
Copy link
Contributor

gjabell commented Jan 9, 2019

Describe the bug
After installing baker from source, the baker command fails because it cannot locate Spinner.js in cluster.js and interactive.js.

To Reproduce

  1. Clone the baker repo and switch to dev branch.
  2. Run npm install and npm link.
  3. Attempt to run the baker command.

Expected behavior
The baker command runs successfully without failing from import errors.

Please complete the following information:

  • OS: Arch Linux 64-bit
  • Version: Kernel 4.20.0
@gjabell gjabell mentioned this issue Jan 9, 2019
Merged
@ssmirr ssmirr closed this as completed in #91 Jan 9, 2019
ssmirr pushed a commit that referenced this issue Jan 9, 2019
@gjabell @ssmirr
fix: fixed invalid imports. (#91)
ebda70c 
Fixes #90.

Changes proposed in this pull request:
- Fix invalid imports in cluster.js and interactive.js
@ssmirr
Copy link
Collaborator

ssmirr commented Jan 9, 2019

Thanks for reporting and sending a PR to fix this Galen!

Interesting/weird thing is that node on Mac and Windows didn't complain about using ../Spinner instead of ./spinner. Wondering if node checks imports differently on each OS 🤔 .

@gjabell
Copy link
Contributor Author

gjabell commented Jan 9, 2019

I think Linux has stricter rules when it comes to case-sensitivity. I've even had issues with database tables not being recognized if they are capitalized vs. lowercase, so I wouldn't be surprised if node is the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssmirr @gjabell