Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the max-diff value gets rounded internally? #82

Closed
florianbrinkmann opened this issue Aug 24, 2021 · 4 comments
Closed

Does the max-diff value gets rounded internally? #82

florianbrinkmann opened this issue Aug 24, 2021 · 4 comments

Comments

@florianbrinkmann
Copy link

I have a comparision with a very small difference value (0.00036101398601399). When I use exactly that value for the max-diff config value, the check fails. Increasing it to something like 0.00037101398601399 works, so I wondered if there is some rounding done internally?

@MediaMarco
Copy link
Member

Thanks for your report! We found out that max-diff is read as float from the config, but the calculated difference is a double internally. That leads to this rounding error. We'll fix this soonish.

@florianbrinkmann
Copy link
Author

You’re welcome, thanks for looking into it!

@MediaMarco
Copy link
Member

The fix is included in Release 4.3.4 - your problem should hopefully be solved.

@florianbrinkmann
Copy link
Author

Thanks a lot! Just updated to the new version, I will keep an eye on it and, if there still is a problem, reopen that issue here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants