[IMP] Increase buffer for jobs check in _query_requeue_dead_jobs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PeterC10
commented
Feb 11, 2025
PeterC10
commented
- Up check for jobs enqueued so that they have been enqueued for at least 5 minutes
- Don't requeue any job that isn't older than 5 minutes
- There are cases when Odoo is busy that a job may stay in enqueued for more than 10 seconds, upping to 5 minutes will be more than enough of a buffer if there is no problem with the Odoo instance
PeterC10
force-pushed
the
11.0_requeue_dead_jobs_increase_buffer
branch
from
aa39889 to
de0ddee
Compare
* Job Queue Lock model added to track jobs being actively processed by Odoo
* Any job not being actively worked on will either be:
* Requeued, if max_retries not reached
* Marked as failed, if max_retries reached
* Covers cases where the Odoo instance is restarted or a job is killed by
Odoo due to exceeding the limit_time_cpu setting
Backport of enhancement from Odoo 16 PR on OCA: OCA#716
…ocks * Move the check for dead jobs until after wait_notification * Up check for jobs enqueued so that they have been enqueued for at least 5 minutes * Don't requeue any job that isn't older than 5 minutes * Use advisory locks for job_queue_lock so that the locks can persist for the session and not be lost if the transaction is committed at any point whilst the job is running or being marked as done * Avoids potential for Odoo to inadvertantly requeue a job that is still running or has finished but not marked the job as done yet
PeterC10
force-pushed
the
11.0_requeue_dead_jobs_increase_buffer
branch
from
de0ddee to
c88f17b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.