Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add monsters walking back to spawn" #3610

Closed
wants to merge 1 commit into from

Conversation

nekiro
Copy link
Member

@nekiro nekiro commented Aug 28, 2021

Reverts #3604

It doesn't work properly.

Copy link
Contributor

@MillhioreBT MillhioreBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do not fully satisfy what we would expect from this mechanism.

@marmichalski
Copy link
Contributor

so why not just fix it? 🙄

@MillhioreBT
Copy link
Contributor

so why not just fix it? 🙄

If you still keep the branch, do it, fix it and then push the changes, i suppose this revert is in case you don't decide to fix it.

@marmichalski
Copy link
Contributor

This happens because of how poor A* is in TFS. I'll just chunk the path, so it does not have to check high count of nodes at once 🙄.

@lgrossi
Copy link

lgrossi commented Aug 29, 2021

Would be nice to know the reason of the revert. That way people of other repositories can see it and maybe help to improve/fix. It's also an amazing way of keeping log for the future. 😁

@marmichalski
Copy link
Contributor

Would be nice to know the reason of the revert. That way people of other repositories can see it and maybe help to improve/fix. It's also an amazing way of keeping log for the future. 😁

#3604 (comment)
#3610 (comment)

PR with solution has been opened.

@lgrossi
Copy link

lgrossi commented Aug 29, 2021

Would be nice to know the reason of the revert. That way people of other repositories can see it and maybe help to improve/fix. It's also an amazing way of keeping log for the future. 😁

#3604 (comment)
#3610 (comment)

PR with solution has been opened.

Thanks for linking it, I think it's important to have some visibility in the revert PR.

@DSpeichert
Copy link
Member

Reverting isn't necessary if the author is providing a fix quickly.

@nekiro nekiro closed this Sep 17, 2021
@nekiro nekiro deleted the revert-3604-monster-spawn-walk branch September 17, 2021 07:45
DSpeichert pushed a commit that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants