-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add monsters walking back to spawn" #3610
Conversation
This reverts commit 5a4558d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes do not fully satisfy what we would expect from this mechanism.
so why not just fix it? 🙄 |
If you still keep the branch, do it, fix it and then push the changes, i suppose this revert is in case you don't decide to fix it. |
This happens because of how poor A* is in TFS. I'll just chunk the path, so it does not have to check high count of nodes at once 🙄. |
Would be nice to know the reason of the revert. That way people of other repositories can see it and maybe help to improve/fix. It's also an amazing way of keeping log for the future. 😁 |
#3604 (comment) PR with solution has been opened. |
Thanks for linking it, I think it's important to have some visibility in the revert PR. |
Reverting isn't necessary if the author is providing a fix quickly. |
Reverts #3604
It doesn't work properly.