Add Node.js 8 to Travis CI test matrix #115
Conversation
|
Looks good to me |
|
@hayes I probably didn't explain my self very well, but I wanted to fix the Node.js 8 bugs before merging this. I can see that you opened #118 to revert this, but it was closed instead of being merged? I think it's better to revert so that other PR's don't have to spend time debugging a false positive. |
|
@watson this was my bad, I misinterpreted the failures as being related to the same node bug that was affecting v7. I am hoping to just get the test fix for. Node 8 merged today, but if you think it would be better to revert I would be happy to do that. I still have a little digging to do too understand why the results are a little different |
|
Nah, I didn't expect a fix for 8 so soon, so if we are close to merging then let's just keep 8 in master |
The tests are currently failing on Node.js 8 and I'm not that familiar with the test suite yet, so I need some help reading the output and hopefully making the tests pass.
There's already a PR open that fixes some of the tests, but not all of them (#110).
If someone could explain how to interpret the error output from the tests, it would be awesome 😃