Fmt installation via Cmake #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fmt is one of the dependencies, without it code won't compile. So, I decided, it will be a lot more convient for user to download fmt in case it is not found on his system.
Besides, when I tried to install fmt via
sudo apt install libfmt-devcommand execution on my Ubuntu machine, I got an error just like this - fmtlib/fmt#2769. Code didn't compiled because of it.This error is fixed in newer versions of fmt, but version inside apt is pretty old.
My fix will make occurrence of error above almost imposible, because cmake will install fmt from master branch of fmt repository.