Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-result-array-groups rule #351

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Add prefer-result-array-groups rule #351

merged 4 commits into from
Oct 4, 2021

Conversation

ota-meshi
Copy link
Owner

close #347

@ota-meshi ota-meshi force-pushed the prefer-result-array-groups branch from 5bb7dd1 to e2e5432 Compare October 2, 2021 21:57
@ota-meshi ota-meshi marked this pull request as ready for review October 2, 2021 22:03
RunDevelopment
RunDevelopment requested changes Oct 3, 2021
View reviewed changes
Copy link
Collaborator

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Just a few minor nits.

lib/rules/prefer-result-array-groups.ts Outdated Show resolved Hide resolved
docs/rules/prefer-result-array-groups.md Outdated Show resolved Hide resolved
docs/rules/prefer-result-array-groups.md Outdated Show resolved Hide resolved
docs/rules/prefer-result-array-groups.md Outdated Show resolved Hide resolved
lib/rules/prefer-result-array-groups.ts Outdated Show resolved Hide resolved
ota-meshi and others added 2 commits October 4, 2021 14:12
@ota-meshi @RunDevelopment
Apply suggestions from code review
6d9cf7d 
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@ota-meshi
TS support and add testcases.
6a498f0
@RunDevelopment RunDevelopment merged commit 155f1f4 into master Oct 4, 2021
@RunDevelopment RunDevelopment deleted the prefer-result-array-groups branch October 4, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add regexp/prefer-result-array-groups rule
2 participants
@ota-meshi @RunDevelopment