feat/refactor: clean-up !with parameter parsing & add more param support #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minisbett
requested review from
cmyui,
skrungly,
NiceAesth,
tsunyoku and
7mochi
as code owners
cmyui
reviewed
Feb 28, 2024
|
|
||
| result = app.usecases.performance.calculate_performances( | ||
| osu_file_path=str(BEATMAPS_PATH / f"{bmap.id}.osu"), | ||
| scores=[score_args], # calculate one score | ||
| ) | ||
|
|
||
| return "{msg}: {pp:.2f}pp ({stars:.2f}*)".format( | ||
| msg=" ".join(msg_fields), | ||
| return "{pp:.2f}pp ({stars:.2f}*)".format( |
There was a problem hiding this comment.
I think we should keep the msg here is nice in the sense that from in-game, it's easy to tell whether or not the server correctly parsed the params you send
It'll be quite nice now that the parsing is split into a function -- we can have a format__with__args(score_args) -> str and test that similarly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related Issues / Projects
Checklist