[memory][scs][parser] Don't generate arcs from sc-element classes #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaZotov
force-pushed
the
feat/skip_generating_type_arcs
branch
3 times, most recently
from
98d16df to
6ac65a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 95.49% 95.54% +0.05%
==========================================
Files 236 236
Lines 26037 26419 +382
Branches 1827 1837 +10
==========================================
+ Hits 24863 25241 +378
- Misses 1174 1178 +4 |
kilativ-dotcom
requested changes
Nov 12, 2024
NikitaZotov
force-pushed
the
feat/skip_generating_type_arcs
branch
2 times, most recently
from
c053422 to
b1904dc
Compare
kilativ-dotcom
requested changes
Nov 18, 2024
sc-memory/sc-memory/tests/sc-memory/units/templates/test_sc_templates_scs.cpp
Show resolved
Hide resolved
kilativ-dotcom
requested changes
Nov 25, 2024
kilativ-dotcom
requested changes
Nov 29, 2024
kilativ-dotcom
requested changes
Dec 2, 2024
kilativ-dotcom
requested changes
Dec 3, 2024
kilativ-dotcom
requested changes
Dec 5, 2024
NikitaZotov
force-pushed
the
feat/skip_generating_type_arcs
branch
from
e1bf70b to
d617099
Compare
…lement types have not only outgoig base sc-arcs
…ture; fix adding triples with two sc-element types; fix adding hanging sc-element types
…o sc-element type
NikitaZotov
force-pushed
the
feat/skip_generating_type_arcs
branch
from
ce172e5 to
2786023
Compare
kilativ-dotcom
requested changes
Dec 18, 2024
…lement with and withour constancy masks
kilativ-dotcom
requested changes
Dec 26, 2024
kilativ-dotcom
requested changes
Jan 11, 2025
Comment on lines
504
to
505
| ScType const & sourceTypeWithConstancySubtype = sourceType.BitAnd(ScType::Const | ScType::Var); | ||
| ScType const & targetTypeWithConstancySubtype = targetType.BitAnd(ScType::Const | ScType::Var); |
There was a problem hiding this comment.
I've spent a lot of time to understand that they are constancy subtype of type provided by source keynode and constancy subtype of target
maybe rename these variables?
There was a problem hiding this comment.
What about sourceTypeWithoutConstancySubtype and sourceTypeWithoutConstancySubtype?
There was a problem hiding this comment.
maybe constancySubtypeProvidedBySourceKeynode and constancyTargetSubtype?
looks like we interpret these variables in different ways
| ScType const & sourceTypeWithConstancySubtype = sourceType.BitAnd(ScType::Const | ScType::Var); | ||
| ScType const & targetTypeWithConstancySubtype = targetType.BitAnd(ScType::Const | ScType::Var); | ||
| bool doSourceAndTargetHaveCompatibleConstancySubtypes = | ||
| sourceTypeWithConstancySubtype.CanExtendTo(targetTypeWithConstancySubtype) |
There was a problem hiding this comment.
some lines like this one have space at the end
will this be fixed with clang?
sc-memory/sc-memory/tests/sc-memory/units/scs-helper/test_scs_helper.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/scs-helper/test_scs_helper.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, sc-arcs between sc-element types and sc-elements are not generated in sc-memory. This allows for: