Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove codegen #65

Merged
merged 26 commits into from
Dec 11, 2024
Merged

Refactor/remove codegen #65

merged 26 commits into from
Dec 11, 2024

Conversation

MakarenkoAI
Copy link
Collaborator

No description provided.

@MakarenkoAI MakarenkoAI changed the title Fix/new api Refactor/remove codegen Sep 17, 2024
@MakarenkoAI MakarenkoAI self-assigned this Sep 17, 2024
Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comments and it'll look ok 👍

Copy link
Collaborator

@Malina09 Malina09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the system not build because of this mismatched naming, I think that's why ci doesn't pass.

scripts/build_kb.sh Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
scripts/run_py_ps.sh Outdated Show resolved Hide resolved
scripts/set_vars.sh Outdated Show resolved Hide resolved
scripts/set_vars.sh Outdated Show resolved Hide resolved
scripts/run_sc_web.sh Outdated Show resolved Hide resolved
Copy link
Member

@NikitaZotov NikitaZotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge for now, we'll fix the build on macOS when we move project to the new build system

Copy link
Collaborator

@Malina09 Malina09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well!

@MakarenkoAI MakarenkoAI merged commit 46a7ce9 into main Dec 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants