Sspace #61
Open
Sspace #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MksmOrlov
requested changes
Aug 2, 2024
| @@ -1,2 +1,4 @@ | |||
| add_subdirectory(identifiers-module) | |||
| add_subdirectory(sections-module) | |||
| add_subdirectory(sspace-search-module) | |||
| add_subdirectory(utils-module) | |||
There was a problem hiding this comment.
do not copy utils, use it from sc-machine
|
|
||
| #include "sc-core/sc_memory.h" | ||
|
|
||
| //extern sc_addr keynode_question_erase_elements; |
There was a problem hiding this comment.
remove commented code. Check everywhere
|
|
||
| #include "sc-core/sc_helper.h" | ||
| #include "sc-core/sc_memory_headers.h" | ||
| #include <stdbool.h> |
|
|
||
| sc_result agent_search_extensional_closure(const sc_event * event, sc_addr arg) | ||
| { | ||
| sc_addr question, answer; |
There was a problem hiding this comment.
Suggested change
| sc_addr question, answer; | |
| sc_addr action, answer; |
question is deprecated
|
|
||
| if (sc_iterator3_next(it1) == SC_TRUE) { | ||
| printf("agent search extensional closure: found element\n"); | ||
| if (sc_helper_check_arc(s_default_ctx,back,sc_iterator3_value(it1,2),sc_type_arc_pos_const_temp)!=SC_TRUE) { |
There was a problem hiding this comment.
it is the first usage of back, so it is always true. Remove this if
|
|
||
| answer = create_answer_node(); | ||
| sc_addr front, back = sc_memory_node_new(s_default_ctx,sc_type_const); | ||
| SYSTEM_ELEMENT(back); |
There was a problem hiding this comment.
I think we don't need to make it system element because you delete this node in the end of this agent. Also I am not sure if we need to make system elements in this agent everywhere
|
|
||
| sc_iterator3_free(it1); | ||
|
|
||
| bool f = true; |
| } | ||
| sc_iterator3_free(it2); | ||
|
|
||
| it2 = sc_iterator3_a_f_a_new(s_default_ctx, 0, sc_iterator3_value(it1, 2), 0); |
There was a problem hiding this comment.
sc_iterator3_value(it1, 2) is node, not connector (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.