Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: optimize dependencies with sc-machine #20

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

CMakeLists.txt Outdated Show resolved Hide resolved
docs/changelog.md Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@FallenChromium FallenChromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code refactoring should've been a separate PR since I haven't found a way to "view changes from all commits except some specific commits in the middle of the list".

The codestyle change for C++ codebase is questionable because it looks too harsh on the eyes, makes the identifiers longer and steers naming convention from "object-properties-and-role-in-name" to "description-of-the-action-of-the-object", which becomes evident when you compare C codestyle to C++ codestyle.

Codestyle changes for Python looks reasonable but I'm not a python dev to comment on this. Again, it should've been a separate PR with different reviewers

As of build system changes and docs, I've left some comments that I think are critical.

@MksmOrlov MksmOrlov removed their request for review April 14, 2024 19:03
@NikitaZotov NikitaZotov force-pushed the fix/cmake_deps branch 2 times, most recently from 49aa16b to 81414a7 Compare April 15, 2024 04:22
@NikitaZotov NikitaZotov merged commit e871fc8 into ostis-ai:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants