-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: optimize dependencies with sc-machine #20
Conversation
platform-dependent-components/problem-solver/cxx/CMakeLists.txt
Outdated
Show resolved
Hide resolved
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code refactoring should've been a separate PR since I haven't found a way to "view changes from all commits except some specific commits in the middle of the list".
The codestyle change for C++ codebase is questionable because it looks too harsh on the eyes, makes the identifiers longer and steers naming convention from "object-properties-and-role-in-name" to "description-of-the-action-of-the-object", which becomes evident when you compare C codestyle to C++ codestyle.
Codestyle changes for Python looks reasonable but I'm not a python dev to comment on this. Again, it should've been a separate PR with different reviewers
As of build system changes and docs, I've left some comments that I think are critical.
a47ddc6
to
fab99c2
Compare
49aa16b
to
81414a7
Compare
81414a7
to
d9d2d08
Compare
Rebased on #12
Dependencies: