Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the template lexical environment #66

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

aisbergg
Copy link
Contributor

I like to implement a tag, that require the full lexical context (bindings) to be copied. Currently the render.Context interface exposes the Get and Set function to manipulate the bindings, but those don't let me iterate over the whole thing. Thus, this PR adds a function that returns the full bindings. Usage example:

func (tc tagContext) myTag(rc render.Context) (s string, err error) {
	bindings := rc.Bindings()
	...
}

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@aisbergg aisbergg changed the title Expose the template lexical context Expose the template lexical environment Apr 22, 2022
@danog danog merged commit 3170e91 into osteele:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants