Add stream_id in the http_callback interface callback of on_publish #2838

stormbirds · 2022-01-03T19:12:42Z

#2837
Added the stream ID attribute in the on_publish callback event, currently only implemented for rtmp connection, not yet understood the process for rtc.

TRANS_BY_GPT3

codecov-commenter · 2022-01-03T19:18:09Z

Codecov Report

Merging #2838 (144fb82) into feature/gb28181 (72ad526) will decrease coverage by 0.00%.
The diff coverage is 17.54%.

@@                 Coverage Diff                 @@
##           feature/gb28181    #2838      +/-   ##
===================================================
- Coverage            59.86%   59.85%   -0.01%     
===================================================
  Files                  121      121              
  Lines                51333    51353      +20     
===================================================
+ Hits                 30729    30738       +9     
- Misses               20604    20615      +11

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_hooks.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_stream.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | |

Translated to English while maintaining the markdown structure:

Translated to English while maintaining the markdown structure:

| trunk/src/app/srs_app_rtc_source.hpp | 9.09% <ø> (ø) | |
| trunk/src/app/srs_app_rtmp_conn.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_source.cpp | 0.66% <0.00%> (ø) | |
| trunk/src/app/srs_app_statistic.cpp | 28.22% <42.10%> (+0.67%) | ⬆️ |
| ... and 2 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 72ad526...144fb82. Read the comment docs.

TRANS_BY_GPT3

winlinvip · 2022-01-04T01:35:28Z

👍 Take matters into your own hands, and you will have enough clothing and food.

TRANS_BY_GPT3

jinleileiking · 2022-01-04T02:26:54Z

trunk/src/app/srs_app_rtmp_conn.cpp

-        return srs_error_wrap(err, "rtmp: callback on publish");
-    }
-
+    std::string stream_id = "vid-" + srs_random_str(7);


stream_id has already been generated, right? There is no need to generate it again here.

TRANS_BY_GPT3

According to the URL, it is better to obtain the statistic stream object and then retrieve the ID.

TRANS_BY_GPT3

It is better to obtain the statistic stream object based on the URL and then retrieve the ID.

I just tested it and it is possible to obtain the statistic stream object through the URL. This method is actually more reasonable. Previously, I didn't think of it because I haven't looked at the SRS source code much. I will submit a new method here, so I suggest closing this PR. Also, thank you for providing the idea.

TRANS_BY_GPT3

jinleileiking · 2022-01-04T02:28:04Z

trunk/src/app/srs_app_rtmp_conn.cpp

@@ -825,17 +826,18 @@ srs_error_t SrsRtmpConn::publishing(SrsLiveSource* source)
            return srs_error_wrap(err, "rtmp: referer check");
        }
    }
-
-    if ((err = http_hooks_on_publish()) != srs_success) {
-        return srs_error_wrap(err, "rtmp: callback on publish");


This part has been deleted, cannot be restored, and will not invoke this hook anymore?

TRANS_BY_GPT3

duiniuluantanqin · 2022-01-04T02:43:39Z

The changes you made are too significant.
17 files and a series of interfaces have been modified. What if we need app_id/vhost_id/param_id in the future?
And this hasn't even involved rtc and gb yet.

Can we refer to the handling method of server_id?

obj->set("server_id", SrsJsonAny::str(stat->server_id().c_str()));

Alternatively, we can discuss other more reasonable approaches.

ps:
#2837 (comment)
After reviewing your requirements, can't the app and stream be combined into one continuous flow? I don't think the stream_id is necessary.

TRANS_BY_GPT3

stormbirds · 2022-01-04T09:58:29Z

This change you made is too big. 17 files, a series of interfaces have been modified. What if we need app_id/vhost_id/param_id in the future? And this hasn't even involved rtc and gb yet.

Can we refer to the handling method of server_id?
obj->set("server_id", SrsJsonAny::str(stat->server_id().c_str()));
Or we can discuss other more reasonable approaches.

ps: #2837 (comment) I went back to look at your requirement, can't the app+stream determine the stream? I feel like stream_id is not necessary.

Yes, it can be determined. The problem is that every time I need this stream information, I have to request the streams API to fetch the entire list, and then compare and filter out the streams that meet the criteria. I think it would be better to directly retrieve the specific information of this stream using the streams?id=streamId method.

TRANS_BY_GPT3

stormbirds · 2022-01-04T12:57:48Z

This change you made is too big. 17 files, a series of interfaces have been modified. What if we need app_id/vhost_id/param_id in the future? And this hasn't even involved rtc and gb yet.

Can we refer to the handling method of server_id?
obj->set("server_id", SrsJsonAny::str(stat->server_id().c_str()));
Or we can discuss other more reasonable approaches.

ps: #2837 (comment) I went back to look at your requirement, can't the app+stream determine the stream together? I feel like stream_id is not necessary.

Also, if multiple playback requests in gb28181 use the same app and stream, it seems that it is impossible to distinguish which specific stream.

TRANS_BY_GPT3

在on_publish的http_callback接口回调中增加stream_id

144fb82

winlinvip requested a review from duiniuluantanqin January 4, 2022 01:35

winlinvip assigned duiniuluantanqin Jan 4, 2022

winlinvip linked an issue Jan 4, 2022 that may be closed by this pull request

Hope to add the stream_id attribute in the on_publish callback interface. #2837

Closed

jinleileiking reviewed Jan 4, 2022

View reviewed changes

stormbirds closed this Jan 4, 2022

winlinvip changed the title ~~在on_publish的http_callback接口回调中增加stream_id~~ Add stream_id in the http_callback interface callback of on_publish Jul 29, 2023

winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stream_id in the http_callback interface callback of on_publish #2838

Add stream_id in the http_callback interface callback of on_publish #2838

stormbirds commented Jan 3, 2022 •

edited by winlinvip

Loading

codecov-commenter commented Jan 3, 2022 •

edited by winlinvip

Loading

winlinvip commented Jan 4, 2022 •

edited

Loading

jinleileiking Jan 4, 2022 •

edited by winlinvip

Loading

winlinvip Jan 4, 2022 •

edited

Loading

stormbirds Jan 4, 2022 •

edited by winlinvip

Loading

winlinvip Jan 5, 2022

jinleileiking Jan 4, 2022 •

edited by winlinvip

Loading

duiniuluantanqin commented Jan 4, 2022 •

edited by winlinvip

Loading

stormbirds commented Jan 4, 2022 •

edited by winlinvip

Loading

stormbirds commented Jan 4, 2022 •

edited by winlinvip

Loading

Add stream_id in the http_callback interface callback of on_publish #2838

Add stream_id in the http_callback interface callback of on_publish #2838

Conversation

stormbirds commented Jan 3, 2022 • edited by winlinvip Loading

codecov-commenter commented Jan 3, 2022 • edited by winlinvip Loading

Codecov Report

winlinvip commented Jan 4, 2022 • edited Loading

jinleileiking Jan 4, 2022 • edited by winlinvip Loading

Choose a reason for hiding this comment

winlinvip Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

stormbirds Jan 4, 2022 • edited by winlinvip Loading

Choose a reason for hiding this comment

winlinvip Jan 5, 2022

Choose a reason for hiding this comment

jinleileiking Jan 4, 2022 • edited by winlinvip Loading

Choose a reason for hiding this comment

duiniuluantanqin commented Jan 4, 2022 • edited by winlinvip Loading

stormbirds commented Jan 4, 2022 • edited by winlinvip Loading

stormbirds commented Jan 4, 2022 • edited by winlinvip Loading

stormbirds commented Jan 3, 2022 •

edited by winlinvip

Loading

codecov-commenter commented Jan 3, 2022 •

edited by winlinvip

Loading

winlinvip commented Jan 4, 2022 •

edited

Loading

jinleileiking Jan 4, 2022 •

edited by winlinvip

Loading

winlinvip Jan 4, 2022 •

edited

Loading

stormbirds Jan 4, 2022 •

edited by winlinvip

Loading

jinleileiking Jan 4, 2022 •

edited by winlinvip

Loading

duiniuluantanqin commented Jan 4, 2022 •

edited by winlinvip

Loading

stormbirds commented Jan 4, 2022 •

edited by winlinvip

Loading

stormbirds commented Jan 4, 2022 •

edited by winlinvip

Loading