Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRT: Fix srt2rtmp crash when streamid is too long(#2770) #2786

Merged
merged 1 commit into from
Dec 27, 2021
Merged

SRT: Fix srt2rtmp crash when streamid is too long(#2770) #2786

merged 1 commit into from
Dec 27, 2021

Conversation

akanchi
Copy link
Contributor

@akanchi akanchi commented Dec 11, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021 •
edited by winlinvip
Loading

Codecov Report

Merging #2786 (9d79f85) into 4.0release (1a4249d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           4.0release    #2786   +/-   ##
===========================================
  Coverage       60.32%   60.32%           
===========================================
  Files             121      121           
  Lines           50972    50972           
===========================================
  Hits            30747    30747           
  Misses          20225    20225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English:

Δ = absolute <relative> (impact), ø = not affected, ? = missing data'
Powered by Codecov. Last update 1a4249d...9d79f85. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

@akanchi Thanks a lot
@runner365 Please review this PR, appreciate that.

@winlinvip winlinvip linked an issue Dec 16, 2021 that may be closed by this pull request
SRT: SRS will crash if streamid is too long #2770
Closed
chundonglinlin
chundonglinlin reviewed Dec 26, 2021
View reviewed changes
trunk/src/srt/srt_to_rtmp.cpp
@@ -15,6 +15,7 @@
#include <srs_app_config.hpp>
#include <srs_kernel_stream.hpp>
#include <list>
#include <sstream>
Copy link
Member

@chundonglinlin chundonglinlin Dec 26, 2021 •
edited by winlinvip
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #include <sstream> has already been imported in the srs_app_config.hpp header file, so there is no need to repeat #include <sstream>.

TRANS_BY_GPT3

Copy link
Member

@chundonglinlin chundonglinlin Dec 26, 2021 •
edited by winlinvip
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash issue has been verified and there are no other problems by using stringstream instead of a char array. Thanks to @akanchi for the pull request.

TRANS_BY_GPT3

@winlinvip winlinvip merged commit f1a448b into ossrs:4.0release Dec 27, 2021
@winlinvip
Copy link
Member

Merged, thanks a lot @akanchi @runner365 @chundonglinlin

@akanchi akanchi deleted the fix-issue-2770 branch December 27, 2021 13:23
chundonglinlin added a commit to chundonglinlin/srs that referenced this pull request Dec 28, 2021
@chundonglinlin
SRT: Eliminate duplicate header file.(ossrs#2786)
797b5bc
winlinvip pushed a commit that referenced this pull request Dec 29, 2021
@chundonglinlin
SRT: Eliminate duplicate header file.(#2786) (#2827)
a16590b
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chundonglinlin chundonglinlin chundonglinlin left review comments

@runner365 runner365 runner365 approved these changes

Assignees

@runner365 runner365

Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SRT: SRS will crash if streamid is too long
5 participants
@akanchi @codecov-commenter @winlinvip @chundonglinlin @runner365