Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the same 'client_id' error when asynchronous call #2665

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

duiniuluantanqin
Copy link
Member

No description provided.


SrsRtcAsyncCallOnStop::SrsRtcAsyncCallOnStop(SrsContextId c, SrsRequest * r)
{

Copy link
Member Author

@duiniuluantanqin duiniuluantanqin Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification here is to remove the ^M symbol, the same applies below.

TRANS_BY_GPT3

@@ -194,6 +195,12 @@ srs_error_t SrsVodStream::serve_m3u8_ctx(ISrsHttpResponseWriter * w, ISrsHttpMes
srs_assert(hr);

SrsRequest* req = hr->to_request(hr->host())->as_http();
// discovery vhost, resolve the vhost from config
SrsConfDirective* parsed_vhost = _srs_config->get_vhost(req->vhost);
Copy link
Member Author

@duiniuluantanqin duiniuluantanqin Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 199-202 search for vhost to resolve the issue of inconsistent stream IDs in the statistics information.

TRANS_BY_GPT3

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #2665 (b4d150a) into develop (b874d9c) will decrease coverage by 0.38%.
The diff coverage is 16.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2665      +/-   ##
===========================================
- Coverage    59.91%   59.52%   -0.39%     
===========================================
  Files          121      121              
  Lines        50902    51240     +338     
===========================================
+ Hits         30497    30500       +3     
- Misses       20405    20740     +335     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_rtc_conn.cpp | 10.40% <0.00%> (-0.03%) | ⬇️ |
| trunk/src/app/srs_app_http_static.cpp | 45.79% <55.55%> (+0.38%) | ⬆️ |
| trunk/src/protocol/srs_rtmp_handshake.cpp | 83.95% <0.00%> (-0.18%) | ⬇️ |
| trunk/src/app/srs_app_hls.cpp | 0.00% <0.00%> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_hls.cpp | 0.00% <0.00%> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update b874d9c...b4d150a. Read the comment docs.

TRANS_BY_GPT3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
3 participants