fix bug: last segment of ts not trigger 'on_hls' #2438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug: last segment of ts not trigger 'on_hls', because of 'on_unpublish' earlier than 'segment_close',
see #2068
Phenomenon: After the streaming ends, the last HLS segment does not trigger
on_hls
.Cause: In the function
SrsHlsController::on_unpublish()
,on_unpublish
occurs earlier thansegment_close
, causing the notification of the last segment to be forgotten in the tasks.Solution: Place
on_unpublish
aftersegment_close
.TRANS_BY_GPT3