Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statistics module returns the resolution of the video. #471

Closed
haofz opened this issue Aug 28, 2015 · 4 comments
Closed

The statistics module returns the resolution of the video. #471

haofz opened this issue Aug 28, 2015 · 4 comments
Assignees
Labels
Feature It's a new feature. TransByAI Translated by AI/GPT.
Milestone

Comments

@haofz
Copy link
Contributor

haofz commented Aug 28, 2015

Question: I have tried streaming with OBS and SRS publishers, but the video resolution parsed by codec.video_avc_demux() is inaccurate (tried several times with SRS 2.0, all resolutions are larger than the actual resolution, while SRS 1.0 shows 0x0).

Log (SRS 2.0): [2015-08-28 11:38:19.753][trace][2823][117] start publish mr=0/350, p1stpt=20000, pnt=20000, tcp_nodelay=0, rtcid=120
[2015-08-28 11:38:21.074][trace][2823][117] got metadata, width=854, height=480
[2015-08-28 11:38:21.166][trace][2823][117] 46B video sh, codec(7, profile=Main, level=5.1, 1280x640, 0kbps, 0fps, 0s)
Note: The original video resolution is 854x480, but the resolution parsed by the codec is 1280x640.

Additionally, the statistic module (SrsStatisticStream) does not include the video resolution. Can this be considered?

TRANS_BY_GPT3

@winlinvip winlinvip added the Bug It might be a bug. label Aug 28, 2015
@winlinvip winlinvip added this to the srs 2.0 release milestone Aug 28, 2015
@winlinvip
Copy link
Member

winlinvip commented Aug 28, 2015

This seems to have a bug, but I'm not sure how to parse the width and height from the 264 raw bitstream.

TRANS_BY_GPT3

@wenjiegit
Copy link
Contributor

wenjiegit commented Aug 28, 2015

srs will not change the resolution of the video. The video resolution is written in the sequence header, which is generated by the encoder. Srs will not modify this value. I have always used OBS for streaming, and VLC and other players can play it normally. The resolution in the metadata is useless for the decoder, and only the value in the sequence header is considered.

TRANS_BY_GPT3

@winlinvip winlinvip changed the title codec.video_avc_demux()解析的分辨率不准确或缺失的问题 统计模块返回视频的分辨率 Aug 28, 2015
@winlinvip winlinvip added Feature It's a new feature. and removed Bug It might be a bug. labels Aug 28, 2015
@winlinvip winlinvip modified the milestones: srs 3.0 release, srs 2.0 release Aug 28, 2015
@winlinvip
Copy link
Member

winlinvip commented Aug 28, 2015

Analyzing the resolution issue, Jie is more knowledgeable about it. He said there is no problem, so I will close it.
Regarding the resolution returned by the statistics module, I have changed the title and included it in SRS3 for support.

TRANS_BY_GPT3

@winlinvip winlinvip reopened this Aug 28, 2015
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
@winlinvip winlinvip linked a pull request Oct 8, 2021 that will close this issue
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
Bepartofyou added a commit to Bepartofyou/srs that referenced this issue Oct 8, 2021
@winlinvip
Copy link
Member

Fixed

@winlinvip winlinvip changed the title 统计模块返回视频的分辨率 The statistics module returns the resolution of the video. Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature It's a new feature. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants