fix(publish): improve stdout #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
fix/publish-improve-stdout
branch
from
dd66d07 to
62ce3f7
Compare
kettanaito
force-pushed
the
fix/publish-improve-stdout
branch
from
62ce3f7 to
f7a2944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios when Release notifies about the exited publish script but prints nothing into stdout. I believe that happens due to the nature of
execAsyncand how it accumulates stdout/stderr.I'm opting into using
execdirectly here, relying on the deferred promise of that execution.execshould pipe the stdio into the parent's process, printing the data as it comes in.