Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Note that LGTM service is deprecated. #2339

Merged
merged 1 commit into from
Oct 14, 2022
Merged

📖 Note that LGTM service is deprecated. #2339

merged 1 commit into from
Oct 14, 2022

Conversation

wenottingham
Copy link
Contributor

What kind of change does this PR introduce?

Docs update to note that LGTM is a deprecated service (GitHub is shutting it down, and it's not taking new signups).

What is the current behavior?

LGTM is listed with other SAST tools.

What is the new behavior (if this is a feature change)?**

LGTM is marked as deprecated.

Which issue(s) this PR fixes

Fixes #2259

Special notes for your reviewer

Does this PR introduce a user-facing change?

``
NONE

@wenottingham wenottingham temporarily deployed to integration-test October 7, 2022 19:53 Inactive
@codecov
Copy link

codecov bot commented Oct 7, 2022 •
edited
Loading

Codecov Report

Merging #2339 (8358e14) into main (7f214bf) will not change coverage.
The diff coverage is n/a.

❗ Current head 8358e14 differs from pull request most recent head a3cf5b8. Consider uploading reports for the commit a3cf5b8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2339   +/-   ##
=======================================
  Coverage   40.55%   40.55%           
=======================================
  Files         112      112           
  Lines        8822     8822           
=======================================
  Hits         3578     3578           
  Misses       4984     4984           
  Partials      260      260

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Integration tests success for
[8e164e1]
(https://github.com/ossf/scorecard/actions/runs/3207299539)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test October 7, 2022 20:58 Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Integration tests success for
[a94dfe7]
(https://github.com/ossf/scorecard/actions/runs/3207644661)

naveensrinivasan
naveensrinivasan reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenottingham Can you please sign your commits? I meant the DCO. Thanks

@naveensrinivasan
Copy link
Member

@olivekl 👀 Please

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test October 11, 2022 13:26 Inactive
@github-actions
Copy link

Integration tests success for
[3ed09da]
(https://github.com/ossf/scorecard/actions/runs/3227218902)

olivekl
olivekl approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments. Thanks!

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) October 11, 2022 15:08
auto-merge was automatically disabled October 11, 2022 19:32

Head branch was pushed to by a user without write access

@wenottingham wenottingham temporarily deployed to integration-test October 11, 2022 19:32 Inactive
@wenottingham
Copy link
Contributor Author

@wenottingham Can you please sign your commits? I meant the DCO. Thanks

👍

@github-actions
Copy link

Integration tests success for
[9226d8c]
(https://github.com/ossf/scorecard/actions/runs/3229687129)

azeemshaikh38
azeemshaikh38 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to run make generate-docs ?

@wenottingham wenottingham temporarily deployed to integration-test October 13, 2022 14:19 Inactive
@wenottingham wenottingham temporarily deployed to integration-test October 13, 2022 14:22 Inactive
@github-actions
Copy link

Integration tests success for
[02638b7]
(https://github.com/ossf/scorecard/actions/runs/3243136305)

@github-actions
Copy link

Integration tests success for
[b4192aa]
(https://github.com/ossf/scorecard/actions/runs/3243156131)

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) October 13, 2022 15:01
auto-merge was automatically disabled October 13, 2022 18:52

Head branch was pushed to by a user without write access

@wenottingham wenottingham temporarily deployed to integration-test October 13, 2022 18:52 Inactive
@github-actions
Copy link

Integration tests success for
[8358e14]
(https://github.com/ossf/scorecard/actions/runs/3244911894)

@naveensrinivasan
Copy link
Member

@wenottingham Can you please DCO your commits? Then we can merge this fix. Thanks

@wenottingham
Note that LGTM service is deprecated.
a3cf5b8 
Signed-off-by: Bill Nottingham <notting@tidelift.com>
@wenottingham wenottingham temporarily deployed to integration-test October 14, 2022 14:21 Inactive
@github-actions
Copy link

Integration tests success for
[a3cf5b8]
(https://github.com/ossf/scorecard/actions/runs/3250654661)

@naveensrinivasan naveensrinivasan merged commit 36d6a34 into ossf:main Oct 14, 2022
latortuga71 pushed a commit to latortuga71/scorecard that referenced this pull request Oct 27, 2022
@wenottingham
Note that LGTM service is deprecated. (ossf#2339)
e936a6a 
Signed-off-by: Bill Nottingham <notting@tidelift.com>

Signed-off-by: Bill Nottingham <notting@tidelift.com>
Signed-off-by: latortuga <latortugaaaa>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
@wenottingham
Note that LGTM service is deprecated. (ossf#2339)
f38ce3e 
Signed-off-by: Bill Nottingham <notting@tidelift.com>

Signed-off-by: Bill Nottingham <notting@tidelift.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
@wenottingham
Note that LGTM service is deprecated. (ossf#2339)
d65cac6 
Signed-off-by: Bill Nottingham <notting@tidelift.com>

Signed-off-by: Bill Nottingham <notting@tidelift.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
@wenottingham @raghavkaul
Note that LGTM service is deprecated. (ossf#2339)
546da54 
Signed-off-by: Bill Nottingham <notting@tidelift.com>

Signed-off-by: Bill Nottingham <notting@tidelift.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveensrinivasan naveensrinivasan naveensrinivasan left review comments

@olivekl olivekl olivekl approved these changes

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@laurentsimon laurentsimon Awaiting requested review from laurentsimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: LGTM is going away
4 participants
@wenottingham @naveensrinivasan @azeemshaikh38 @olivekl