Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Modify tool installation #2288

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

Signed-off-by: Azeem Shaikh azeemshaikh38@gmail.com

Part of #2287. Improves consistency of installed tool behavior.

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #2288 (def0406) into main (0f87094) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2288   +/-   ##
=======================================
  Coverage   41.17%   41.17%           
=======================================
  Files         110      110           
  Lines        8774     8774           
=======================================
  Hits         3613     3613           
  Misses       4892     4892           
  Partials      269      269           

@github-actions
Copy link

Integration tests success for
[22d33e3]
(https://github.com/ossf/scorecard/actions/runs/3101663297)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test September 21, 2022 23:52 Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) September 21, 2022 23:53
@github-actions
Copy link

Integration tests success for
[28ba987]
(https://github.com/ossf/scorecard/actions/runs/3101879842)

@github-actions
Copy link

Integration tests success for
[2b36a54]
(https://github.com/ossf/scorecard/actions/runs/3101978767)

@github-actions
Copy link

Integration tests success for
[e890506]
(https://github.com/ossf/scorecard/actions/runs/3102027116)

@github-actions
Copy link

Integration tests success for
[2603cc8]
(https://github.com/ossf/scorecard/actions/runs/3102590207)

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
@github-actions
Copy link

Integration tests success for
[def0406]
(https://github.com/ossf/scorecard/actions/runs/3102824016)

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 merged commit 08c2ee5 into ossf:main Sep 22, 2022
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Sep 28, 2022
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants