🌱 cron: make CSV header optional (3/n) #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
=======================================
Coverage 44.45% 44.45%
=======================================
Files 95 95
Lines 7987 7987
=======================================
Hits 3551 3551
Misses 4173 4173
Partials 263 263 |
azeemshaikh38
approved these changes
Sep 13, 2022
Signed-off-by: Spencer Schrock <sschrock@google.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Sep 23, 2022
* Make CSV header optional. Signed-off-by: Spencer Schrock <sschrock@google.com> * Appease linter. Signed-off-by: Spencer Schrock <sschrock@google.com> * Address PR feedback. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: N8BWert <n8.wert.b@gmail.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Make CSV header optional. Signed-off-by: Spencer Schrock <sschrock@google.com> * Appease linter. Signed-off-by: Spencer Schrock <sschrock@google.com> * Address PR feedback. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: N8BWert <n8.wert.b@gmail.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Make CSV header optional. Signed-off-by: Spencer Schrock <sschrock@google.com> * Appease linter. Signed-off-by: Spencer Schrock <sschrock@google.com> * Address PR feedback. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: N8BWert <n8.wert.b@gmail.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Schrock sschrock@google.com
What kind of change does this PR introduce?
Part of a series of refactors to generalize the cron infrastructure to enable re-use by the ossf criticality score project
What is the current behavior?
CSV files read by the controller needed to have a header line:
What is the new behavior (if this is a feature change)?**
The header line is now optional, and is skipped by the
data.csvIterator.Which issue(s) this PR fixes
Follow up PR for #2235
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)