✨ Allow contents: write for Token-Permissions when doing mvn release #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvn release:prepare makes changes to the repo to bump versions, create a tag, and get things prepared for doing a release build and thus needs contents: write permissions. This looks for workflow steps that call `mvn release:prepare` and includes them in the set that are a releasing workflow and thus which allow contents:write
katzj
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
katzj
changed the title
|
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #2202 +/- ##
==========================================
- Coverage 41.92% 41.87% -0.06%
==========================================
Files 95 95
Lines 7935 7945 +10
==========================================
Hits 3327 3327
- Misses 4348 4358 +10
Partials 260 260 |
laurentsimon
approved these changes
Aug 26, 2022
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This allows workflow steps that call 'mvn release:prepare' to use
contents: writepermissions as they are needed for doing the maven release process.(Is it a bug fix, feature, docs update, something else?)
Somewhere between a bug and a feature
What is the current behavior?
Current behavior is that a workflow that is doing mvn release will get dinged on the Token-Permissions check due to
contents: writepermission for that workflowWhat is the new behavior (if this is a feature change)?**
A workflow using
mvn release:preparewill be allowed thecontents: writepermission without lowering the scoreWhich issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?