Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove duplicate projects with different casings #2155

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix: there is URL duplication simply due to projects specified with unique casings. This PR fixes that.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test August 16, 2022 21:26 Inactive
@wenottingham
Copy link
Contributor

We noticed that when canonicalizing repos on our end we'd end up with "duplicate" scorecards for a particular repo definition - this looks like it would fix that to me! Thanks for looking into it.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #2155 (b20062b) into main (2f253e8) will increase coverage by 2.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2155      +/-   ##
==========================================
+ Coverage   42.59%   45.01%   +2.41%     
==========================================
  Files          94       94              
  Lines        7815     7815              
==========================================
+ Hits         3329     3518     +189     
+ Misses       4228     4032     -196     
- Partials      258      265       +7     

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) August 16, 2022 21:39
@github-actions
Copy link

Integration tests success for
[b20062b]
(https://github.com/ossf/scorecard/actions/runs/2871167325)

@azeemshaikh38 azeemshaikh38 merged commit d2b3496 into main Aug 16, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/projects branch August 16, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants