✨ Scorecard returns a non-zero exit code if any check has a runtime error #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2133 +/- ##
==========================================
- Coverage 42.46% 42.42% -0.04%
==========================================
Files 94 94
Lines 7840 7846 +6
==========================================
Hits 3329 3329
- Misses 4253 4259 +6
Partials 258 258 |
|
Integration tests success for |
azeemshaikh38
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
LGTM with comment. Thanks for picking this up @spencerschrock!
2 tasks
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Scorecard now returns a non-zero exit code if any checks return a runtime error.
What is the current behavior?
Scorecard returns an exit code of 0 if most checks have runtime errors
What is the new behavior (if this is a feature change)?**
Scorecard now returns an exit code of 1 in the same scenarios
Which issue(s) this PR fixes
Fixes #2124
Special notes for your reviewer
Had to modify a few existing checks to conform to the new semantics.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)