Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pom.xml support for sonarype SAST #2114

Merged
merged 4 commits into from
Aug 3, 2022
Merged

feat: Add pom.xml support for sonarype SAST #2114

merged 4 commits into from
Aug 3, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Aug 1, 2022 •
edited
Loading

See #2085

/cc @edwardsph

@laurentsimon laurentsimon mentioned this pull request Aug 1, 2022
Closed
@laurentsimon laurentsimon temporarily deployed to integration-test August 1, 2022 20:48 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test August 1, 2022 20:49 Inactive
@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #2114 (6bbdf8f) into main (7de9713) will increase coverage by 0.30%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   42.44%   42.75%   +0.30%     
==========================================
  Files          93       93              
  Lines        7598     7681      +83     
==========================================
+ Hits         3225     3284      +59     
- Misses       4123     4141      +18     
- Partials      250      256       +6

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Integration tests success for
[d822c87]
(https://github.com/ossf/scorecard/actions/runs/2777773098)

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Integration tests success for
[3fb7329]
(https://github.com/ossf/scorecard/actions/runs/2777777946)

azeemshaikh38
azeemshaikh38 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments.

checks/sast.go Outdated Show resolved Hide resolved
checks/sast.go Outdated Show resolved Hide resolved
checks/sast.go Show resolved Hide resolved
aidenwang9867
aidenwang9867 reviewed Aug 3, 2022
View reviewed changes
checks/sast.go Outdated Show resolved Hide resolved
@laurentsimon laurentsimon temporarily deployed to integration-test August 3, 2022 19:29 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) August 3, 2022 19:29
@laurentsimon laurentsimon temporarily deployed to integration-test August 3, 2022 19:29 Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Integration tests success for
[d9dd32f]
(https://github.com/ossf/scorecard/actions/runs/2791948702)

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Integration tests success for
[6bbdf8f]
(https://github.com/ossf/scorecard/actions/runs/2791952350)

@laurentsimon laurentsimon merged commit ae4d09c into ossf:main Aug 3, 2022
@edwardsph
Copy link

Thanks for the quick change - looking forward to testing in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidenwang9867 aidenwang9867 aidenwang9867 left review comments

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurentsimon @edwardsph @azeemshaikh38 @aidenwang9867