-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Language struct and optimize result parsing for GHClient.ListProgrammingLanguages #1992
Conversation
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
+ Coverage 50.40% 52.94% +2.53%
==========================================
Files 88 88
Lines 7225 7236 +11
==========================================
+ Hits 3642 3831 +189
+ Misses 3337 3152 -185
- Partials 246 253 +7 |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides @azeemshaikh38 's comment, no further comment from me!
Integration tests success for |
What kind of change does this PR introduce?
A follow-up PR on PR#1979.
Modify
type Language string
totype LanguageName string
inclients/languages.go
.Add a new struct
type Language struct {LanguageName, LoC}
inclients/languages.go
.Add support for interface
ListProgrammingLanguages
to parse the returned JSON to a list ofLanguage
.Add more language name const:
CMake
andDockerFile
PR title follows the guidelines defined in our pull request documentation
Does this PR introduce a user-facing change?
No.