Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have a single binary name across all platforms #4517

Closed
timothysparg opened this issue Feb 11, 2025 · 1 comment · Fixed by #4520
Closed

have a single binary name across all platforms #4517

timothysparg opened this issue Feb 11, 2025 · 1 comment · Fixed by #4520
Labels
kind/enhancement New feature or request

Comments

@timothysparg
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When installing Scorecard with tools like ubi, it becomes cumbersome to handle the current naming scheme (e.g., scorecard_5.0.0_darwin_arm64). Each platform has a distinct binary name, which complicates automation and tooling.

Describe the solution you'd like
Provide a single binary name across all platforms. For non-Windows, call the binary scorecard; for Windows, call it scorecard.exe. The release artifacts could remain named for each OS and architecture (e.g., scorecard_5.0.0_darwin_arm64.tar.gz) but once extracted, the binary inside would simply be scorecard (or scorecard.exe for Windows).

Describe alternatives you've considered
n/a

Additional context
@timothysparg timothysparg added the kind/enhancement New feature or request label Feb 11, 2025
spencerschrock added a commit to spencerschrock/scorecard that referenced this issue Feb 11, 2025
@spencerschrock
use scorecard as binary name for all builds
b205893 
Previously, the binary name included the build platform which
complicated running Scorecard after extracting the tarball.

ossf#4517

Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock added a commit to spencerschrock/scorecard that referenced this issue Feb 11, 2025
@spencerschrock
use scorecard as binary name for all builds
41b721a 
Previously, the binary name included the build platform which
complicated running Scorecard after extracting the tarball. As all
binaries now share the same name, we need a unique folder for each
binary, so also removes `no_unique_dist_dir`.

ossf#4517

Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock added a commit to spencerschrock/scorecard that referenced this issue Feb 11, 2025
@spencerschrock
use scorecard as binary name for all release builds
6e05c1f 
Previously, the binary name included the build platform which
complicated running Scorecard after extracting the tarball. As all
binaries now share the same name, we need a unique folder for each
binary, so also removes `no_unique_dist_dir`.

ossf#4517

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock mentioned this issue Feb 11, 2025
Closed
2 tasks
@spencerschrock
Copy link
Member

While I mainly build from source as a maintainer, this has definitely bitten me before. It was an easy fix, so trying to get this in before the next release.

timothysparg added a commit to timothysparg/scorecard that referenced this issue Feb 11, 2025
@timothysparg
feat: create binary without OS and arch in name
8fd7743 
Previously binaries were created with their architecture and OS included as part of their binary name.

Removing the `binary: scorecard-<linux|darwin|windows>-{{ .Arch }}` line allows us to collapse all of the different build configs into a single universal build that caters for [linux,darwin,windos]*[arm64,amd64]

`- -buildmode=exe` was not needed on the windows builds and was also removed.

closes ossf#4517

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>
@timothysparg timothysparg mentioned this issue Feb 11, 2025
Merged
2 tasks
spencerschrock pushed a commit that referenced this issue Feb 12, 2025
@timothysparg
🌱 remove OS and Arch info from scorecard release binary name (#4520)
6fc296e 
* feat: create binary without OS and arch in name

Previously binaries were created with their architecture and OS included as part of their binary name.

Removing the `binary: scorecard-<linux|darwin|windows>-{{ .Arch }}` line allows us to collapse all of the different build configs into a single universal build that caters for [linux,darwin,windos]*[arm64,amd64]

`- -buildmode=exe` was not needed on the windows builds and was also removed.

closes #4517

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

* fix: resolve name_template deprecation

As per https://goreleaser.com/deprecations#snapshotname_template `snapshot.name_template` has been replaced with `snapshot.version_template`

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

---------

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>
balteravishay pushed a commit to PrinceAsiedu/scorecard that referenced this issue Feb 17, 2025
@timothysparg @balteravishay
🌱 remove OS and Arch info from scorecard release binary name (ossf#4520)
1e939d8 
* feat: create binary without OS and arch in name

Previously binaries were created with their architecture and OS included as part of their binary name.

Removing the `binary: scorecard-<linux|darwin|windows>-{{ .Arch }}` line allows us to collapse all of the different build configs into a single universal build that caters for [linux,darwin,windos]*[arm64,amd64]

`- -buildmode=exe` was not needed on the windows builds and was also removed.

closes ossf#4517

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

* fix: resolve name_template deprecation

As per https://goreleaser.com/deprecations#snapshotname_template `snapshot.name_template` has been replaced with `snapshot.version_template`

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

---------

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>
Signed-off-by: balteravishay <avishay.balter@gmail.com>
balteravishay pushed a commit to PrinceAsiedu/scorecard that referenced this issue Feb 26, 2025
@timothysparg @balteravishay
🌱 remove OS and Arch info from scorecard release binary name (ossf#4520)
00f5845 
* feat: create binary without OS and arch in name

Previously binaries were created with their architecture and OS included as part of their binary name.

Removing the `binary: scorecard-<linux|darwin|windows>-{{ .Arch }}` line allows us to collapse all of the different build configs into a single universal build that caters for [linux,darwin,windos]*[arm64,amd64]

`- -buildmode=exe` was not needed on the windows builds and was also removed.

closes ossf#4517

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

* fix: resolve name_template deprecation

As per https://goreleaser.com/deprecations#snapshotname_template `snapshot.name_template` has been replaced with `snapshot.version_template`

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>

---------

Signed-off-by: Tim Sparg <6872586+timothysparg@users.noreply.github.com>
Signed-off-by: balteravishay <avishay.balter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
Scorecard - NEW
Status: Done
Milestone
No milestone
2 participants
@spencerschrock @timothysparg