maild rework #1842
Closed
maild rework #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll need to figure out a better way to find it before actually creating a PR for this.
Reported by Jeremy Stott in issue ossec#1838
Trying to re-use the code in the way I did was a mistake. This duplicates it, but significantly reduces the complexity. While here, pass the mail config directly to the osdns() daemon. Now this information doesn't have to pass in the imsg itself. Less memory stuff going on. Still needs a lot of cleanup.
This reverts commit 7dc0815.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got too ambitious with the osdns stuff, and tried to combine too much.
This simplifies things for maild by just integrating it there. I'll do the same for remoted later.
Instead of trying to pass the smtp server in the imsg, we just pass the configuration to
maild_osdns()and grab it there. Simplifies memory management and solves some crashes I've been seeing.Only tested on OpenBSD 6.6-current at the moment, as I've found myself linux-less.