-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
391 add company picture attribut to jobs #423
Open
DipandaAser
wants to merge
25
commits into
main
Choose a base branch
from
391-add-picture-oder-avatar-attribut-to-jobs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rakici review needed |
port 7000 is used on mac < montery
b5e1d08
to
c5f4346
Compare
c5f4346
to
4670fb2
Compare
50c438e
to
07e3997
Compare
elhmn
requested changes
Aug 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks great, I left few comments. I also think it would be great to add test for the image size if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the post jobs offer handler to accept a new field for the company picture
Add a new handler to retreive the company picture
Why ?
To allow job poster to add their company image on thiers job post
How?
We have added an S3 self hosted object storage called minio
ROUTES:
"/jobs" POST
: post a job (ther_is a new field calledcompany_image
who take a base64 encoding of and image)"/jobs/{jobID}/image" GET
: get the job company image"/jobs" GET
: get the jobs list (in every job there is a field namedhas_image
bool)Steps to verify:
move to the backend folder with cd ./backend
run
make start-postrges
to run an initialized databaserun
make run
to launch the apirun
make e2etest
to run the test** Screenshots (optional)