Black Duck: Add a mechanism to set the origin-id for a package via a label curation. #9819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
black-duck-origin-id-curation-mechanism
branch
4 times, most recently
from
2fdc0d5 to
3df3785
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/advisors/black-duck/src/funTest/kotlin/ResponseCachingComponentServiceClient.kt
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9819 +/- ##
=========================================
Coverage 68.07% 68.07%
Complexity 1285 1285
=========================================
Files 249 249
Lines 8828 8828
Branches 918 918
=========================================
Hits 6010 6010
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
black-duck-origin-id-curation-mechanism
branch
from
3df3785 to
99cae52
Compare
sschuberth
reviewed
Jan 23, 2025
Comment on lines
52
to
60
| val index = coordinates.indexOf(':') | ||
| require(index != -1) { | ||
| "Could not parse originId '$coordinates'. Missing ':' separator ." | ||
| } | ||
|
|
||
| return BlackDuckOriginId( | ||
| externalNamespace = coordinates.substring(0, index), | ||
| externalId = coordinates.substring(index + 1, coordinates.length) | ||
| ) |
There was a problem hiding this comment.
Alternatively:
val parts = coordinates.split(':', limit = 2)
require(parts.size == 2) {
"Could not parse originId '$coordinates'. Missing ':' separator ."
}
return BlackDuckOriginId(externalNamespace = parts[0], externalId = parts[1])
Prepare for adding a test for querying by origin-id. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-origin-id-curation-mechanism
branch
from
99cae52 to
5234a50
Compare
By default, the vulnerabilities are queried by the respective purl. This does not work in all cases, e.g.: 1. Some origins do not (yet) have a purl associated. 2. For some ecosystem, querying by purl doesn't work, even though the data sets have a purl. 3. The knowledge base may not contain a data set for the exact package but for the same "package" in a different ecosystem. For example, query vulnerabilities for the "ubuntu" package instead of for the "github" package. So, allow to set the origin-id via a package label curation, to override the origin for which the vulnerabilities shall be retrieved. Note: Since the amount of external namespaces is rather large, test the querying only for a few ecosystems. This should be fine, because there is very little namespace specific logic in ORT's code involved. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-origin-id-curation-mechanism
branch
from
5234a50 to
44c9067
Compare
sschuberth
approved these changes
Jan 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of: #8739.