chore(helper-cli): Drop the obsolete command to create analyzer results #9224
+0
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command had been introduced years ago to support migrating to a newer ScanCode version, e.g. scan already scanned packages with a newer ScanCode version to avoid performance temporary poor execution times due to no chache hits. Nowadays the scanning is provenance based, so triggering a re-scan would be better done by provenance, as opposed to by package. So, remove the command, because it is no more appropriate. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
helper-cli-delete-create-analyzer-result-command
branch
from
88f118b
to
3f50356
Compare
sschuberth
approved these changes
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9224 +/- ##
============================================
+ Coverage 67.10% 67.65% +0.55%
+ Complexity 1187 1185 -2
============================================
Files 240 239 -1
Lines 7904 7795 -109
Branches 908 899 -9
============================================
- Hits 5304 5274 -30
+ Misses 2232 2153 -79
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command had been introduced years ago to support migrating to a newer ScanCode version, e.g. scan already scanned packages with a newer ScanCode version to avoid performance dtemporary poor execution times due to no chache hits.
Nowadays the scanning is provenance based, so triggering a re-scan would be better done by provenance, as opposed to by package. So, remove the command, because it is no more appropriate.