Node fun test improvements III #9185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9185 +/- ##
=========================================
Coverage 67.10% 67.10%
Complexity 1187 1187
=========================================
Files 240 240
Lines 7908 7908
Branches 914 914
=========================================
Hits 5307 5307
Misses 2233 2233
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
node-fun-test-improvements-iii
branch
2 times, most recently
from
ef0fe4b
to
88ae698
Compare
|
FYI,
|
Use a dedicated expected result file for each respective test, to allow for maintaining them independently. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Consistently use `expected-output` as suffix, and align the name of the expected result for skipping scope excludes with `yarn2-project-with-lockfile-skip-excluded-scopes-expected-output.yml`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Reduce the repetition a bit. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
node-fun-test-improvements-iii
branch
from
88ae698
to
d0db7ff
Compare
sschuberth
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up organization of expected result files.