Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the GradleInspector to use the dependency graph #9073

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (c01b6c8) to head (96d3916).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9073   +/-   ##
=========================================
  Coverage     68.42%   68.42%           
  Complexity     1165     1165           
=========================================
  Files           238      238           
  Lines          7646     7646           
  Branches        871      871           
=========================================
  Hits           5232     5232           
  Misses         2056     2056           
  Partials        358      358           
Flag Coverage Δ
funTest-docker 67.22% <ø> (ø)
funTest-non-docker 34.16% <ø> (ø)
test 38.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Prepare for reuse and also perform some minor generalizations. As part of
that, hard-code the "Gradle" project type in order to not be dependent on
a package manager instance.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This simplifies the code a bit.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
See [1] for context.

[1]: #3825

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth requested review from fviernau and a team September 4, 2024 10:52
@sschuberth sschuberth merged commit 080b303 into main Sep 4, 2024
23 checks passed
@sschuberth sschuberth deleted the gi-dep-graph branch September 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants