-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate git-repo manifest parsing from Jackson to KxS #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By now generators share the common `AbstractBomGenerator` class. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8827 +/- ##
=========================================
Coverage 67.79% 67.79%
Complexity 1164 1164
=========================================
Files 243 243
Lines 7711 7711
Branches 861 861
=========================================
Hits 5228 5228
Misses 2127 2127
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
requested changes
Jul 2, 2024
fviernau
requested changes
Jul 3, 2024
plugins/reporters/cyclonedx/src/main/kotlin/CycloneDxReporter.kt
Outdated
Show resolved
Hide resolved
plugins/reporters/cyclonedx/src/main/kotlin/CycloneDxReporter.kt
Outdated
Show resolved
Hide resolved
The `FileFormat` enum is meant for ORT internal use in combination with object mappers. However, no object mappers are used as the CycloneDX library itself does the mapping. So simply use the file extensions to distinguish between the output formats. This is a preparation for removing `FileFormat.XML` which depends on Jackson's XML mapper. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Use xmlutil as a serializer for KxS to parse git-repo manifests. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
fviernau
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.