Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate git-repo manifest parsing from Jackson to KxS #8827

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

By now generators share the common `AbstractBomGenerator` class.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth requested a review from a team as a code owner July 2, 2024 19:42
@sschuberth sschuberth enabled auto-merge (rebase) July 2, 2024 19:42
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (01f347e) to head (6b18607).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8827   +/-   ##
=========================================
  Coverage     67.79%   67.79%           
  Complexity     1164     1164           
=========================================
  Files           243      243           
  Lines          7711     7711           
  Branches        861      861           
=========================================
  Hits           5228     5228           
  Misses         2127     2127           
  Partials        356      356           
Flag Coverage Δ
funTest-non-docker 33.96% <ø> (ø)
test 38.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The `FileFormat` enum is meant for ORT internal use in combination with
object mappers. However, no object mappers are used as the CycloneDX
library itself does the mapping. So simply use the file extensions to
distinguish between the output formats.

This is a preparation for removing `FileFormat.XML` which depends on
Jackson's XML mapper.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Use xmlutil as a serializer for KxS to parse git-repo manifests.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth merged commit 78fb986 into main Jul 3, 2024
20 checks passed
@sschuberth sschuberth deleted the git-repo-xml branch July 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants