Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability refactorings #7762

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Vulnerability refactorings #7762

merged 3 commits into from
Oct 31, 2023

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (10b0bd8) 67.81% compared to head (da13183) 67.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7762      +/-   ##
============================================
+ Coverage     67.81%   67.85%   +0.04%     
- Complexity     2044     2055      +11     
============================================
  Files           352      356       +4     
  Lines         16832    16879      +47     
  Branches       2381     2395      +14     
============================================
+ Hits          11415    11454      +39     
- Misses         4427     4429       +2     
- Partials        990      996       +6     
Flag Coverage Δ
funTest-docker 67.85% <ø> (ø)
funTest-non-docker 36.16% <3.33%> (-0.26%) ⬇️
test 34.60% <83.33%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
advisor/src/main/kotlin/advisors/NexusIq.kt 0.00% <ø> (ø)
advisor/src/main/kotlin/advisors/OssIndex.kt 76.36% <ø> (ø)
advisor/src/main/kotlin/advisors/Osv.kt 63.44% <100.00%> (ø)
advisor/src/main/kotlin/advisors/VulnerableCode.kt 78.00% <ø> (ø)
.../src/main/kotlin/config/VulnerabilityResolution.kt 100.00% <ø> (ø)
...ain/kotlin/config/VulnerabilityResolutionReason.kt 100.00% <ø> (ø)
...del/src/main/kotlin/utils/ConfigurationResolver.kt 0.00% <ø> (ø)
...src/main/kotlin/utils/DefaultResolutionProvider.kt 0.00% <ø> (ø)
model/src/main/kotlin/utils/ResolutionProvider.kt 0.00% <ø> (ø)
...l/src/main/kotlin/vulnerabilities/Vulnerability.kt 100.00% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

For a better overview, split out CVSS classes to separate files in a new
"vulnerabilities" sub-package of the ORT model. A plural name for the
package was chosen to align with the "licenses" sub-package.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This can be replaced now with plain `VulnerabilityReference`s.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth merged commit 4678d88 into main Oct 31, 2023
20 of 21 checks passed
@sschuberth sschuberth deleted the vulns-refactoring branch October 31, 2023 20:51
fviernau added a commit that referenced this pull request May 17, 2024
See [1] and [2].

[1]: #7762
[2]: #8610

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau added a commit that referenced this pull request May 17, 2024
See [1] and [2].

[1]: #7762
[2]: #8610

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants