-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulnerability refactorings #7762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
requested review from
tsteenbe,
MarcelBochtler,
oheger-bosch and
a team
as code owners
October 30, 2023 12:10
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7762 +/- ##
============================================
+ Coverage 67.81% 67.85% +0.04%
- Complexity 2044 2055 +11
============================================
Files 352 356 +4
Lines 16832 16879 +47
Branches 2381 2395 +14
============================================
+ Hits 11415 11454 +39
- Misses 4427 4429 +2
- Partials 990 996 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sschuberth
commented
Oct 30, 2023
sschuberth
force-pushed
the
vulns-refactoring
branch
from
October 30, 2023 19:50
952c852
to
2d3bdce
Compare
sschuberth
force-pushed
the
vulns-refactoring
branch
from
October 31, 2023 08:33
2d3bdce
to
c591525
Compare
For a better overview, split out CVSS classes to separate files in a new "vulnerabilities" sub-package of the ORT model. A plural name for the package was chosen to align with the "licenses" sub-package. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This can be replaced now with plain `VulnerabilityReference`s. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth
force-pushed
the
vulns-refactoring
branch
from
October 31, 2023 08:34
c591525
to
da13183
Compare
mnonnenmacher
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.