Skip to content

Commit

Permalink
analyzer: Remove peerDependencies from NPM / Yarn test assets
Browse files Browse the repository at this point in the history
ORT does not support `peerDependencies` yet [1]. That is mostly because
handling of peer dependencies varies with NPM versions: Some versions do
install them by default, some do not [2]. This results in ORT's functional
tests to fail depending on the NPM version, and as it turns out, they
would fail with the NPM version 7 currently used in ORT's `Dockerfile`.
However, tests succeed on Azure CI which uses NPM 6. Avoid that
inconsistency by simply not using peer dependencies at all for testing for
now.

[1]: #95
[2]: https://nodejs.org/en/blog/npm/peer-dependencies#using-peer-dependencies

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
  • Loading branch information
sschuberth committed Nov 5, 2021
1 parent 9ebfa9c commit ab292d9
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"devDependencies": {
"cson": "~4.1.0"
},
"peerDependencies": {
"tea": "0.x"
},
"optionalDependencies": {
"promise": "~7.3.1"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
"devDependencies": {
"cson": "~4.1.0"
},
"peerDependencies": {
"tea": "0.x"
},
"optionalDependencies": {
"promise": "~7.3.1"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
"devDependencies": {
"cson": "~4.1.0"
},
"peerDependencies": {
"tea": "0.x"
},
"optionalDependencies": {
"promise": "~7.3.1"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
"devDependencies": {
"cson": "~4.1.0"
},
"peerDependencies": {
"tea": "0.x"
},
"optionalDependencies": {
"promise": "~7.3.1"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"devDependencies": {
"cson": "~4.1.0"
},
"peerDependencies": {
"tea": "0.x"
},
"optionalDependencies": {
"promise": "~7.3.1"
}
Expand Down

0 comments on commit ab292d9

Please sign in to comment.