🔧 Fix polishing unit test #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The default seed changed between Julia v1.3 and Julia v1.0. Therefore some of the precomputed accurate solutions in the unit tests are invalid. - I fixed the seed in the polishing unit test and recomputed a valid solution. - The same has to be done in the update matrix unit test. For now, we just disable the test if the Julia version is not v1.0
- Load the polishing problem with known solution from Mosek from a file - Add FileIO to test dependencies
This was referenced May 18, 2020
Merged
blegat
reviewed
May 19, 2020
blegat
reviewed
May 19, 2020
|
Relevant to the seed issue: JuliaLang/julia#30494 |
blegat
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of the precomputed accurate solutions in the unit tests are invalid.