Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast calculation #292

Merged
merged 4 commits into from
Aug 10, 2016
Merged

Fast calculation #292

merged 4 commits into from
Aug 10, 2016

Conversation

talumbau
Copy link
Member

@talumbau talumbau commented Aug 3, 2016

Partial fulfillment of #274

Needs PRs PSLmodels/Tax-Calculator#844 and a PR on https://github.com/OpenSourcePolicyCenter/deploy in order to work successfully

Also needs button to trigger "small data" calculation.

talumbau added 2 commits August 3, 2016 17:27
 - Reduce poll time in javascript
 - Add field to model for latest Tax-Calculator
 - Additional test to ensure that quick dropq function only
   computes one budget year
@talumbau
Copy link
Member Author

talumbau commented Aug 5, 2016

@feenberg @MattHJensen here is what the new button looks like on the TaxBrain page:

screen shot 2016-08-05 at 2 14 27 pm

@talumbau
Copy link
Member Author

talumbau commented Aug 5, 2016

@mistakevin please review the less file changes and input form template changes - thanks!

@talumbau
Copy link
Member Author

talumbau commented Aug 5, 2016

@kevincolten
Copy link
Contributor

LGTM

 - default setting is OFF for quick calculation
 - better logic on quick calc/fast calc on POST
@talumbau talumbau merged commit 81e45f8 into master Aug 10, 2016
@brittainhard brittainhard deleted the fast_calc branch April 4, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants