1.0.2 Release

[brittainhard]

@hdoupe @martinholmer @MattHJensen @GoFroggyRun I've made a milestone for the 1.0.2 release. Can we discuss what fixes and PRs we want in that milestone? I know for sure I want #612 and #589 fixed. Any other suggestions?

[hdoupe]

@brittainhard what do you think about tackling #619? I would like to fix #596, #598, and #607 as soon as possible since they will lead to incorrect results. It appears that solving #619 will take care of #596, #598, and #607. That way we don't have to fix the latter three bugs twice.

I'm interested in working on this if you're busy working on other stuff before the next release.

cc @martinholmer @MattHJensen @GoFroggyRun

[hdoupe]

@brittainhard #622 should be ready to go. This points the TaxBrain urls to the correct version of the relevant package instead of the master repo on github. It also removes the reference to the commit ID.

cc @GoFroggyRun @martinholmer @MattHJensen

[hdoupe]

@brittainhard I have some tests that post reforms to TaxBrain using the requests library and compare the results with those generated by sending the reform data straight to taxcalc. Should we try to include those in this release?

cc @martinholmer @MattHJensen @GoFroggyRun

[brittainhard]

@hdoupe #619 looks like a good fix, and I think i'm the only person that can tackle it. I'll take a look.

In regards to the test PRs, those are always important to have. It would be good if you could associate that code with an issue, and add that issue to the milestone.

[brittainhard]

With #622, I think its better to add issues to these milestones and not PRs. Can you open an issue for that PR?

[GoFroggyRun]

@brittainhard, #611, #621 and #623 should be ready to go as well. It would be great to include them in 1.0.2 release.

[brittainhard]

@GoFroggyRun great, can you add the associated issues to the milestone?

[GoFroggyRun]

@brittainhard it seems that I wasn't able to associate those issues to the milestone, but related issues are #584 and #545.

[brittainhard]

I added them.

[brittainhard]

@GoFroggyRun did you have time to take another look at #613 ?

[hdoupe]

@brittainhard I just opened an issue #625 for PR #622.

[hdoupe]

@brittainhard said

@hdoupe #619 looks like a good fix, and I think i'm the only person that can tackle it. I'll take a look.

Ok sounds good. Let me know if there is anything I can do to help.

[GoFroggyRun]

@brittainhard I did look at it and worked on it for a while, I was not able to, however, arrive at an easy fix. We might have to include that in the next release.

[GoFroggyRun]

@brittainhard it would also be helpful to include #626 in the milestone that resolves #620.

[martinholmer]

@brittainhard said in webapp-public issue #624 wrt TaxBrain release 1.0.2:

#619 looks like a good fix, and I think i'm the only person that can tackle it. I'll take a look.

Being able to implement the TaxBrain changes described in #619 requires Tax-Calculator changes that are not in 0.9.2, but will be included in Tax-Calculator 0.9.3. Would it facilitate your work on #619 if we created 0.9.3 now (or in the next few days)? Please advise.

@MattHJensen @hdoupe @GoFroggyRun

[MattHJensen]

@brittainhard, what's the status of #619? If you aren't already deep into it, I think it makes sense for @hdoupe to do some exploratory work and then pull you in if he runs into trouble.

[brittainhard]

@MattHJensen I was going to start work on it today, but id be willing to focus on other things and just give him some guidance.

[MattHJensen]

@brittainhard said: "but id be willing to focus on other things and just give him some guidance."

Let's give that a try. I think it will be a good learning experience for @hdoupe. Will also be great for you to have more bandwidth to dedicate to reviewing open PRs.

[brittainhard]

Prelease is now up.