Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macroeconomic_elasticity results page share and print buttons broken #617

Open
hdoupe opened this issue Aug 11, 2017 · 6 comments
Open

Macroeconomic_elasticity results page share and print buttons broken #617

hdoupe opened this issue Aug 11, 2017 · 6 comments

Comments

@hdoupe
Copy link
Collaborator

hdoupe commented Aug 11, 2017

On the macro_elasticity results page, the Share and Print buttons do not work.

@martinholmer @brittainhard @PeterDSteinberg @GoFroggyRun

@martinholmer
Copy link
Contributor

The Print button still doesn't work in the TaxBrain 1.0.3 release candidate.
@GoFroggyRun, can you fix these #617 problems along with the naming issue discussed in issue #673?

@martinholmer
Copy link
Contributor

@GoFroggyRun, Can you replace the broken print/download capabilities with the same kind of Print, Copy, CSV buttons that you have showing at the bottom of the Static Results page?

@GoFroggyRun
Copy link
Contributor

@martinholmer, I was planning to, hopefully, include both #616 and #617 in 1.1.0 PB release, as indicated in #700. These buttons for Static/Build table are not immediately extendable to dynamic. So I will have to write something new for dynamic table(s).

@martinholmer
Copy link
Contributor

@GoFroggyRun said in issue #617:

I was planning to, hopefully, include both #616 and #617 in 1.1.0 PB release, as indicated in #700. These buttons for Static/Build table are not immediately extendable to dynamic. So I will have to write something new for dynamic table(s).

Oh, I didn't know you couldn't just reuse the static-results code for the Print, Copy, and CSV actions.
What about the functions prevent them from being used with dynamic results?
Would it be easier to refactor those functions so that they do work on both static and dynamic results pages?

@hdoupe hdoupe added the Future label Jan 17, 2018
@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 21, 2018

@GoFroggyRun Do you have time to work on #616 and #617?

@GoFroggyRun
Copy link
Contributor

@hdoupe Sure. I'll take another look at this while #853 is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants