Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 10-year liabilities table to display Current Law, Reform, and Change. #380

Closed
3 of 4 tasks
MattHJensen opened this issue Oct 24, 2016 · 3 comments
Closed
3 of 4 tasks
Assignees
Labels
Milestone

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented Oct 24, 2016

Currently TB's 10-year liabilities table only displays the delta between baseline and reform. A user requested the capability to see the baseline and reform numbers as well, without having to pick them out of the diagnostic table for each year.

Here is the current table:
image

Here's how we can meet the request:

  • Add a selector above the title: Current Law, Reform, Change.

  • Change the table name to "Total liabilities by calendar year, descriptor", where the descriptor is the name of the selection.

  • The default should be Change.

  • Add tooltip hooks for new buttons

Matt should notify John Sabelhaus when this is complete.

@MattHJensen MattHJensen changed the title Enable 10-year liabilities table to display baseline, reform, and change. Enable 10-year liabilities table to display Current Law, Reform, and Change. Oct 24, 2016
@talumbau
Copy link
Member

talumbau commented Nov 3, 2016

@brendancol we would probably need to make the total liabilities table a new element that is similar to the "tablebuilder" assets. If I provide you the JSON to populate the additional versions of the table (we have the delta data, would just need baseline and reform), can you add the selector and make the table data switch based on the selected value? I'm thinking a drop down for the selector? Sound right? Adding @brendancol to assignees but keeping myself as I need to supply the data.

@MattHJensen
Copy link
Contributor Author

I'm thinking a drop down for the selector? Sound right?

Another option would be three buttons next to each other. Like these, but w one more:
image I defer to @brendancol, though.

@MattHJensen MattHJensen added this to the b1 milestone Nov 4, 2016
@talumbau talumbau changed the title Enable 10-year liabilities table to display Current Law, Reform, and Change. Enable 10-year liabilities table to display Current Law, Reform, and Change. Nov 7, 2016
@talumbau talumbau added the ready label Nov 7, 2016
@talumbau
Copy link
Member

talumbau commented Dec 9, 2016

closed via #413

@talumbau talumbau closed this as completed Dec 9, 2016
@talumbau talumbau removed the ready label Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants