Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues with "Quick Calculation" #306

Closed
1 of 2 tasks
talumbau opened this issue Aug 17, 2016 · 7 comments
Closed
1 of 2 tasks

Known issues with "Quick Calculation" #306

talumbau opened this issue Aug 17, 2016 · 7 comments
Assignees
Milestone

Comments

@talumbau
Copy link
Member

talumbau commented Aug 17, 2016

  • The button does not appear when one chose to the "Edit Parameters" page
  • The indexing scheme for how we choose which worker nodes to select for a job is adversely impacted by Quick Calculations. Essentially, the indexing scheme is set up to increment by "NUM_BUDGET_YEARS" but the counting gets off because Quick Calculations are only for one year. The end result is that regular microsim jobs will have their performance adversely impacted. This will have to be fixed.
@talumbau
Copy link
Member Author

Re-opening until item 1 from above is resolved as well.

@talumbau talumbau reopened this Aug 19, 2016
@martinholmer
Copy link
Contributor

@talumbau, As part of this pull request, can you change DataFrame.sample() random_state to 80 unless the one being used now produces sub-sample results that are even closer to full-sample results than a relative difference of 0.006 (that is, 0.6 percent) as described in Tax-Calculator pull request #869?

@MattHJensen

@talumbau talumbau added the ready label Aug 30, 2016
@talumbau talumbau added this to the b3 milestone Jan 27, 2017
@MattHJensen MattHJensen modified the milestones: b3, b4, b5 Jan 28, 2017
@rrenfrow86 rrenfrow86 assigned brittainhard and unassigned talumbau Mar 24, 2017
@martinholmer
Copy link
Contributor

@MattHJensen, What is the status of TaxBrain "Quick Calculation" issue #306?
Is it safe to recommend in the user documentation the Quick Calculator option?

@MattHJensen
Copy link
Contributor

MattHJensen commented May 8, 2017

What is the status of TaxBrain "Quick Calculation" issue #306?

@martinholmer The quick calculation button is not available on TaxBrain presets, but it is available and working fine from the default input page.

Is it safe to recommend in the user documentation the Quick Calculator option?

Yes, although it would be helpful to add the caveat that it is not available for preset reforms, as some of users may work off of presets.

@martinholmer
Copy link
Contributor

@MattHJensen said:

@martinholmer The quick calculation button is not available on TaxBrain presets, but it is available and working fine from the default input page.

Is it safe to recommend in the user documentation the Quick Calculator option?

Yes, although it would be helpful to add the caveat that it is not available for preset reforms, as some of users may work off of presets.

Yes, I guess it would be helpful in the short run, but since the goal is to make it eventually work for preset reforms, I think I'll leave that transitory detail out of the user documentation.

@MattHJensen
Copy link
Contributor

I think I'll leave that transitory detail out of the user documentation.

Ok, that makes a lot of sense to plan w/ the maintenance burden in mind.

@martinholmer
Copy link
Contributor

As of August 2, 2017, the first bug item mentioned nearly a year ago in webapp-public issue #306 is still not fixed. During the year since #306 was opened, the contents of the puf.csv file used by TaxBrain have changed somewhat, causing a sensible Quick-Calculation subsample to be 5% (not 2%) as described in webapp-public enhancement request #574.

Where do these two remaining TaxBrain Quick-Calculation bug-fixes stand in our priorities?

@brittainhard @PeterDSteinberg @hdoupe @GoFroggyRun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants