Fix for SaveAsTableRule to work with Spark 3.5 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved! |
osopardo1
merged commit 93c9b65
into
osopardo1:upgrade-spark-3.5-delta-3.0
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to fix SaveAsTableRule for Spark 3.5. The problem which causes the QbeastSQLIntegrationTest to fail is that they on the way of transition from TableSpec.properties to TableSpec.options. Also for some reasons writeOptions are always empty and our options like colunsToIndex specified in SQL are included into TableSpec.options instead. So I changed our rule to ensure that the columnsToIndex are available for the Qbeast writing mechanism.