Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some documentation and examples #1697

Merged
merged 2 commits into from
May 4, 2023
Merged

Adds some documentation and examples #1697

merged 2 commits into from
May 4, 2023

Conversation

xfbs
Copy link
Contributor

@xfbs xfbs commented Apr 25, 2023

Adds a little bit of documentation for Oso.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gj
Copy link
Member

gj commented May 1, 2023

Hey @xfbs, thank you so much for doing this! It might take me a bit to get to the review, but it's greatly appreciated.

@xfbs
Copy link
Contributor Author

xfbs commented May 1, 2023

Hey @gj, for sure. If this one goes through I might send some more PRs your way.

Copy link
Member

@gj gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you so much @xfbs 🙇

/// oso.register_class(MyClass::get_polar_class());
/// ```
///
/// Register polar class with customisations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samscott89 will be pleased 🇬🇧

@gj gj merged commit d43ed90 into osohq:main May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants