Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat LP Shares as Swappable Assets #6

Closed
2 tasks done
Tracked by #5
iboss-ptk opened this issue Jun 16, 2023 · 0 comments
Closed
2 tasks done
Tracked by #5

Treat LP Shares as Swappable Assets #6

iboss-ptk opened this issue Jun 16, 2023 · 0 comments

Comments

@iboss-ptk
Copy link
Collaborator

iboss-ptk commented Jun 16, 2023 •
edited
Loading

Tasks
Beta Give feedback
@iboss-ptk iboss-ptk mentioned this issue Jun 16, 2023
Closed
6 tasks
@iboss-ptk iboss-ptk mentioned this issue Jul 17, 2023
Merged
2 tasks
mergify bot pushed a commit to osmosis-labs/osmosis that referenced this issue Jul 28, 2023
@iboss-ptk
feat(x/cosmwasmpool): Sending token_in_max_amount to the contract b…
18dd3f2 
…efore running contract msg (#5855)

## What is the purpose of the change

In order for [transmuter to treat LP shares token as swappable asset](osmosis-labs/transmuter#6), on `SwapExactAmountOut` it needs to burn the expected token in, but previous implementation sends token to the contract after running sudo msg, which means at the time, contract does not have enough token to burn.

This change fix the aforementioned issue by:
- sending `token_in_denom` with `token_in_max_amount` to the contract
- run sudo msg
- send the remaining token back to sender

*(E.g.: This pull request improves documentation of area A by adding ....*

## Testing and Verifying

The existing test is updated to cover the changes

## Documentation and Release Note

  - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`?

Where is the change documented? 
  - [x] Specification (`x/cosmwasmpool/README.md`)
VitalyV1337 pushed a commit to VitalyV1337/osmosis-1 that referenced this issue Jul 31, 2023
@iboss-ptk @VitalyV1337
feat(x/cosmwasmpool): Sending token_in_max_amount to the contract b…
a8f2530 
…efore running contract msg (osmosis-labs#5855)

## What is the purpose of the change

In order for [transmuter to treat LP shares token as swappable asset](osmosis-labs/transmuter#6), on `SwapExactAmountOut` it needs to burn the expected token in, but previous implementation sends token to the contract after running sudo msg, which means at the time, contract does not have enough token to burn.

This change fix the aforementioned issue by:
- sending `token_in_denom` with `token_in_max_amount` to the contract
- run sudo msg
- send the remaining token back to sender

*(E.g.: This pull request improves documentation of area A by adding ....*

## Testing and Verifying

The existing test is updated to cover the changes

## Documentation and Release Note

  - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`?

Where is the change documented? 
  - [x] Specification (`x/cosmwasmpool/README.md`)
iboss-ptk added a commit that referenced this issue May 3, 2024
@iboss-ptk
[audit-fix(#6)] ChangeLimiter missing validation upon update
67c1b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iboss-ptk