Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sqsdomain on main #8714

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Bump sqsdomain on main #8714

merged 3 commits into from
Sep 17, 2024

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 17, 2024

Bump sqsdomain to v0.26.0

Backported here: #8713

@p0mvn p0mvn changed the title Roman/sqsdomainv26main Bump sqsdomain Sep 17, 2024
@p0mvn p0mvn changed the title Bump sqsdomain Bump sqsdomain on main Sep 17, 2024
@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Sep 17, 2024
@p0mvn p0mvn marked this pull request as ready for review September 17, 2024 23:04
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduced in this pull request enhance the handling of taker fees for specific currency pairs, particularly USDT and USDC. A new mapping has been added to associate these denominations with default pool manager taker fees, allowing for symmetrical fee calculations. Additionally, new test cases have been implemented to ensure that the logic for retrieving taker fees is comprehensive, accounting for various combinations of currency pairs.

Changes

File Path Change Summary
ingest/sqs/pools/transformer/pool_transformer_test.go Added mappings for USDT and USDC in the TestConvertPool_EmptyPriceInfoMap_TakerFee function to support symmetrical fee handling.
ingest/sqs/pools/transformer/taker_fee_test.go Introduced new test cases in TestRetrieveTakerFeeToMapIfNotExists for various currency pairs to enhance taker fee retrieval logic.

Possibly related PRs

Suggested labels

A:backport/v26.x

Suggested reviewers


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@cryptomatictrader cryptomatictrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@cryptomatictrader cryptomatictrader merged commit 3e52449 into main Sep 17, 2024
1 check passed
@cryptomatictrader cryptomatictrader deleted the roman/sqsdomainv26main branch September 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants